chore: remove references to Play gRPC from docs#650
Closed
He-Pin wants to merge 1 commit intoapache:mainfrom
Closed
chore: remove references to Play gRPC from docs#650He-Pin wants to merge 1 commit intoapache:mainfrom
He-Pin wants to merge 1 commit intoapache:mainfrom
Conversation
Port upstream akka/akka-grpc@8aa142b8. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
I'm not convinced that we need this. I have no issue with linking to Play gRPC as a related project. We can update our docs to say that it a related project as opposed to being a Pekko project but I'm not sure if we really need to go into that much detail. |
Member
Author
|
Yes, that's why we need to check it manuly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Documentation for Pekko gRPC contained references to the Play gRPC project (
play-grpc), a separate independent project that is not part of Pekko gRPC. These references may confuse users or imply integration support that does not exist in this project.Modification
docs/src/main/paradox/buildtools/gradle.md[Play Framework](...)reference from the supported build tools list indocs/src/main/paradox/overview.mdResult
Documentation now focuses solely on Pekko gRPC's own supported build tools (sbt, Gradle, Maven) without referring users to an unrelated external project.
References